Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Flow for sense #32160

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 25, 2020

Breaking change

Proposed change

Config flow for sense.

  • Fix unique ids so they are actually unique (and migrate the old ones)

  • Fix missing solar production

  • Do not mark sensors available until they have data

  • Multiple sense units are now possible

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* Fix unique ids so they are actually unique (and migrate the old ones)

* Fix missing solar production

* Do not mark sensors available until they have data
@probot-home-assistant
Copy link

Hey there @kbickar, mind taking a look at this pull request as its been labeled with a integration (sense) you are listed as a codeowner for? Thanks!

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #32160 into dev will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32160      +/-   ##
==========================================
+ Coverage   94.73%   94.75%   +0.02%     
==========================================
  Files         767      768       +1     
  Lines       55486    55646     +160     
==========================================
+ Hits        52562    52727     +165     
+ Misses       2924     2919       -5     
Impacted Files Coverage Δ
...istant/components/google_assistant/report_state.py 83.33% <0.00%> (-1.67%) ⬇️
homeassistant/components/alexa/state_report.py 83.63% <0.00%> (-0.63%) ⬇️
...meassistant/components/mqtt/vacuum/schema_state.py 91.13% <0.00%> (-0.59%) ⬇️
homeassistant/components/twitch/sensor.py 96.70% <0.00%> (-0.04%) ⬇️
homeassistant/util/yaml/loader.py 93.58% <0.00%> (ø) ⬆️
homeassistant/components/mqtt/fan.py 97.96% <0.00%> (ø) ⬆️
homeassistant/components/mqtt/lock.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/mqtt/const.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/file/notify.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/gdacs/const.py 100.00% <0.00%> (ø) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90859b8...cc42ba0. Read the comment docs.

@springstan springstan changed the title Config Flow for sense Add Config Flow for sense Feb 25, 2020
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Two final comments.

Dev automation moved this from Needs review to Reviewer approved Feb 25, 2020
@bachya bachya merged commit 3e702c8 into home-assistant:dev Feb 25, 2020
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants