-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Config Flow for sense #32160
Add Config Flow for sense #32160
Conversation
* Fix unique ids so they are actually unique (and migrate the old ones) * Fix missing solar production * Do not mark sensors available until they have data
Codecov Report
@@ Coverage Diff @@
## dev #32160 +/- ##
==========================================
+ Coverage 94.73% 94.75% +0.02%
==========================================
Files 767 768 +1
Lines 55486 55646 +160
==========================================
+ Hits 52562 52727 +165
+ Misses 2924 2919 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Two final comments.
Breaking change
Proposed change
Config flow for sense.
Fix unique ids so they are actually unique (and migrate the old ones)
Fix missing solar production
Do not mark sensors available until they have data
Multiple sense units are now possible
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: