-
-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not report state when closing down #32168
Conversation
Hey there @home-assistant/cloud, @ochlocracy, mind taking a look at this pull request as its been labeled with a integration ( |
Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration ( |
Codecov Report
@@ Coverage Diff @@
## dev #32168 +/- ##
==========================================
- Coverage 94.74% 94.73% -0.01%
==========================================
Files 768 768
Lines 55645 55643 -2
==========================================
- Hits 52720 52716 -4
- Misses 2925 2927 +2 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Should we add a test for this or can we merge this? |
Breaking change
Proposed change
Do not report states to Google/Alexa when we're shutting down Home Assistant.
I think that this is causing the problem in #32087.
Fixes #32087
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: