Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coronavirus updates #32417

Merged
merged 4 commits into from
Mar 3, 2020
Merged

Coronavirus updates #32417

merged 4 commits into from
Mar 3, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Mar 2, 2020

Breaking change

Proposed change

  • Sort countries alphabetically in config flow (suggested by @bbrendon)
  • Update names to include word coronavirus (suggested by @jurriaan)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob added this to the 0.106.4 milestone Mar 2, 2020
@balloob balloob requested a review from frenck March 2, 2020 23:05
@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #32417 into dev will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32417      +/-   ##
==========================================
- Coverage   94.71%    94.7%   -0.01%     
==========================================
  Files         780      780              
  Lines       56305    56305              
==========================================
- Hits        53327    53326       -1     
- Misses       2978     2979       +1
Impacted Files Coverage Δ
homeassistant/components/coronavirus/sensor.py 0% <0%> (ø) ⬆️
...omeassistant/components/coronavirus/config_flow.py 100% <100%> (ø) ⬆️
homeassistant/helpers/entity.py 97.3% <0%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25b94c...f4be605. Read the comment docs.

@jurriaan
Copy link
Contributor

jurriaan commented Mar 2, 2020

This is better, thanks :)

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested it locally and migrated a "broken" state nicely.

"coronavirus" in the title could be "Coronavirus"; Nit-picking

@balloob balloob merged commit fcbea47 into dev Mar 3, 2020
@balloob balloob deleted the corona-updates branch March 3, 2020 01:59
balloob added a commit that referenced this pull request Mar 3, 2020
* Sort countries alphabetically

* Update sensor name

* Add migration to stable unique IDs

* Update sensor.py
@balloob balloob mentioned this pull request Mar 3, 2020
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants