Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out duplicate logbook states #32427

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Mar 3, 2020

Breaking change

Proposed change

Filter out duplicate states based on the state (not attributes). So if a light changes from brightness 50 to 100, don't make a new logbook event.

This should make the logbook more readable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #32427 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32427   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files         780      780           
  Lines       56315    56315           
=======================================
  Hits        53368    53368           
  Misses       2947     2947

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c62961f...580dfff. Read the comment docs.

@springstan
Copy link
Member

FYI I have added two issues that should be fixed by this PR ✌

@balloob balloob merged commit fed2303 into dev Mar 3, 2020
@balloob balloob deleted the filter-duplicate-logbook-states branch March 3, 2020 21:56
@balloob balloob added this to the 0.106.5 milestone Mar 4, 2020
balloob added a commit that referenced this pull request Mar 4, 2020
@balloob balloob mentioned this pull request Mar 4, 2020
@amelchio amelchio mentioned this pull request Mar 7, 2020
20 tasks
@lock lock bot locked and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple identical updates in log Logbook Presence status spam after updating to 0.106
3 participants