Type hint improvements #32905
Type hint improvements #32905
Conversation
|
Hey there @ctalkington, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( |
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
|
Sorry... |
|
|
| @@ -318,7 +319,7 @@ def __init__(self) -> None: | |||
| return await self.async_step_user(user_input=import_config) | |||
|
|
|||
| async def async_step_zeroconf( | |||
| self, discovery_info: Dict[str, Any] = None | |||
| self, discovery_info: Optional[DiscoveryInfoType] = None | |||
There was a problem hiding this comment.
The discovery info sent by the zeroconf integration is different than the ones sent by integrations to their own platforms. Should we still use this? Can't wait for TypedDict to be part of all our supported versions.
There was a problem hiding this comment.
TypedDict is backported via typing-extensions package.
https://pypi.org/project/typing-extensions/
It's one more dependency though.
There was a problem hiding this comment.
We could take the current lack of TypedDict as an opportunity to try and recognize+convert cases where a NamedTuple would do.
| domain: self._async_init_entity_platform(domain, None) | ||
| } | ||
| self._platforms: Dict[ | ||
| Union[str, Tuple[str, Optional[timedelta], Optional[str]]], EntityPlatform |
There was a problem hiding this comment.
timedelta can be part of the key?
Proposed change
Completes helpers.entity_component, adds discovery info type.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: