Config flow for harmony #32919
Merged
Config flow for harmony #32919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
has-tests
integration: harmony
integration: remote
labels
|
Hey there @ehendrix23, mind taking a look at this pull request as its been labeled with a integration ( |
7 tasks
Kane610
requested changes
Mar 18, 2020
|
CI failure is not related |
Thanks for the review. Much appreciated! |
bdraco
force-pushed
the
harmony_config_flow
branch
from
1eca73e
to
904ec60
Compare
|
@bramkragten Thanks for the double check on this. One step closer to yaml zero |
* Fixes unique ids when using XMPP Co-authored-by: Bram Kragten <mail@bramkragten.nl>
bdraco
force-pushed
the
harmony_config_flow
branch
from
904ec60
to
ef37ab4
Compare
|
Repush for ci |
bdraco
commented
Mar 19, 2020
There was a problem hiding this comment.
Tracking cleanups here
https://github.com/bdraco/home-assistant/tree/harmony_config_flow_followups
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Mar 19, 2020
* Address followup review comments from home-assistant#32919
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Mar 19, 2020
* Address followup review comments from home-assistant#32919
bdraco
added a commit
to bdraco/home-assistant
that referenced
this pull request
Mar 19, 2020
* Address followup review comments from home-assistant#32919
20 tasks
bdraco
added a commit
that referenced
this pull request
Mar 20, 2020
* Harmony config flow improvements * Address followup review comments from #32919 * pylint -- catching my naming error * remove leftovers from refactor
balloob
pushed a commit
that referenced
this pull request
Mar 20, 2020
* Update powerwall unique id * Fix somfy optimistic mode when missing in conf (#32995) * Fix optimistic mode when missing in conf #32971 * Ease code using a default value * Client id and secret are now inclusive * Bump aiohomekit to fix Insignia NS-CH1XGO8 and Lennox S30 (#33014) * Axis - Fix char in stream url (#33004) * An unwanted character had found its way into a stream string, reverting f-string work to remove duplication of code and improve readability * Fix failing tests * deCONZ - Add support for Senic and Gira Friends of Hue remote… (#33022) * Update the test * Harmony config flow improvements (#33018) * Harmony config flow improvements * Address followup review comments from #32919 * pylint -- catching my naming error * remove leftovers from refactor * Update powerwall unique id * Update the test Co-authored-by: tetienne <thibaut@etienne.pw> Co-authored-by: Jc2k <john.carr@unrouted.co.uk> Co-authored-by: Robert Svensson <Kane610@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
As this has been migrated to a ssdp discovery config flow, yaml configuration now requires a host/ip to be configured.
Proposed change
Config flow for harmony
Fixes unique ids when using XMPP
Removes 'port' option since the underlying library doesn't consume it
Co-authored-by: Bram Kragten mail@bramkragten.nl
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: