Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service to turn on the switcher device with timer #33235

Merged
merged 7 commits into from
May 9, 2020

Conversation

thecode
Copy link
Member

@thecode thecode commented Mar 25, 2020

Proposed change

Add new service for turning on the device with a timer.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
switcher_kis:
  phone_id: 'REPLACE_WITH_PHONE_ID'
  device_id: 'REPLACE_WITH_DEVICE_ID'
  device_password: 'REPLACE_WITH_DEVICE_PASSWORD'

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@homeassistant
Copy link
Contributor

Hi @thecode,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @TomerFi, mind taking a look at this pull request as its been labeled with a integration (switcher_kis) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Add service to allow turning on the switcher device with timer - "turn_on_with_timer" Add service to turn on the switcher device with timer Mar 29, 2020
@sefininio
Copy link

@TomerFi , @thecode
I'll be happy to help with this PR if code changes are required, to push this further. We need this for creating automations in HA :)

@TomerFi
Copy link
Contributor

TomerFi commented Apr 7, 2020

@thecode
Thank you, I think there are a lot of people waiting for this.
:-)

@TomerFi
Copy link
Contributor

TomerFi commented Apr 7, 2020

@thecode
Please consider adding some test cases for the new service.
Here are the test cases for the existing set_auto_off service.

@yalmog99
Copy link

Is it possible to add multiple switcher devices in with this update (a much requested feature) ?
If not, please consider adding it.

Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit c371002 into home-assistant:dev May 9, 2020
@lock lock bot locked and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants