Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry sense setup later if listing devices times out. #33455

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Mar 31, 2020

Proposed change

There was another place that sense can timeout during config entry setup that needs to be trapped.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added integration: sense small-pr PRs with less than 30 lines. labels Mar 31, 2020
@project-bot project-bot bot added this to Needs review in Dev Mar 31, 2020
@probot-home-assistant
Copy link

Hey there @kbickar, mind taking a look at this pull request as its been labeled with a integration (sense) you are listed as a codeowner for? Thanks!

@bdraco bdraco force-pushed the sense_additional_place_to_trap_timeout branch from 2d5f3b7 to 41ccc26 Compare March 31, 2020 15:10
@bdraco bdraco force-pushed the sense_additional_place_to_trap_timeout branch from 41ccc26 to 7a00e23 Compare March 31, 2020 16:21
@balloob balloob merged commit f085a0c into home-assistant:dev Mar 31, 2020
Dev automation moved this from Needs review to Done Mar 31, 2020
@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants