Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tradfri cover model to the cover entity attributes #33674

Merged
merged 9 commits into from
Apr 9, 2020

Conversation

i00
Copy link
Contributor

@i00 i00 commented Apr 5, 2020

Breaking change

None

Proposed change

Add model info to state attributes for IKEA blinds.

(model may seem like a strange one ... but I literally want an automation to close all of my block-out blinds at night but not bother with my see-through ones)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
Unchanged

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @ggravlingen, mind taking a look at this pull request as its been labeled with a integration (tradfri) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Ikea Blinds - add Battery and other details Add Ikea tradfri blinds battery and other details Apr 5, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We won't accept this PR in its current form. See below.

homeassistant/components/tradfri/cover.py Outdated Show resolved Hide resolved
homeassistant/components/tradfri/cover.py Outdated Show resolved Hide resolved
@ludeeus ludeeus closed this Apr 5, 2020
@i00
Copy link
Contributor Author

i00 commented Apr 5, 2020

@ludeeus sorry, just wondering why this was closed?

@ludeeus ludeeus reopened this Apr 5, 2020
@ludeeus
Copy link
Member

ludeeus commented Apr 5, 2020

Not sure what happened, was looking though it on the mobile app, might have accidentally bumped the close button while scrolling.

@i00 i00 changed the title Add Ikea tradfri blinds battery and other details Add blind model to the blind entity attributes Apr 9, 2020
@MartinHjelmare MartinHjelmare changed the title Add blind model to the blind entity attributes Add tradfri cover model to the cover entity attributes Apr 9, 2020
@MartinHjelmare
Copy link
Member

Thanks!

@ludeeus ludeeus merged commit f2fbe65 into home-assistant:dev Apr 9, 2020
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants