Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve IPP Config Flow #34212

Merged
merged 10 commits into from
Apr 16, 2020
Merged

Improve IPP Config Flow #34212

merged 10 commits into from
Apr 16, 2020

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented Apr 14, 2020 •
edited
Loading

Breaking change

Proposed change

  • config flow: use the NAME zeroconf property value as multiple printers could be at same host and it becomes confusing to tell integrations apart
  • sensors: improve handling of device info and unique id
  • if UUID is missing and serial is provided via IPP device-id attribute, use that for the unique id to try and ensure we get an unique id if its possible

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@ctalkington ctalkington changed the title Improve IPP Config Dlow Improve IPP Config Flow Apr 14, 2020
@balloob balloob merged commit 9d794b8 into home-assistant:dev Apr 16, 2020
@ctalkington ctalkington deleted the ipp-041420 branch April 17, 2020 01:21
MartinHjelmare
MartinHjelmare reviewed Apr 17, 2020
View reviewed changes
homeassistant/components/ipp/config_flow.py
elif unique_id is None:
_LOGGER.debug("Unable to determine unique id from IPP response")

await self.async_set_unique_id(unique_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't set unique id if it's None, right?

homeassistant/components/ipp/config_flow.py

await self.async_set_unique_id(self.discovery_info[CONF_UUID])
await self.async_set_unique_id(unique_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above.

@lock lock bot locked and limited conversation to collaborators Apr 18, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cla-signed has-tests integration: ipp small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ctalkington @balloob @MartinHjelmare @homeassistant