Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi - refactor entity management #34367

Merged

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Apr 18, 2020

Breaking change

Proposed change

Revisit all of entity management of UniFi integration based on @MartinHjelmare feedback in #34307

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@Kane610
Copy link
Member Author

Kane610 commented Apr 18, 2020

@MartinHjelmare this is a draft of just sensor platform to get feedback from you if this is more in line with what you requested in #34307

@Kane610 Kane610 force-pushed the unifi-refactor_management_of_entities branch from 57221db to 55203bb Compare April 18, 2020 09:55
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

homeassistant/components/unifi/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/unifi/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/unifi/sensor.py Outdated Show resolved Hide resolved
@Kane610 Kane610 force-pushed the unifi-refactor_management_of_entities branch from 9aa1445 to 191d795 Compare April 18, 2020 17:32
@Kane610 Kane610 marked this pull request as ready for review April 18, 2020 21:04
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@Kane610
Copy link
Member Author

Kane610 commented Apr 19, 2020

@MartinHjelmare fixed. Thanks! Will merge when tests pass unless you have additional comments

@Kane610 Kane610 merged commit e5a861d into home-assistant:dev Apr 19, 2020
@Kane610 Kane610 deleted the unifi-refactor_management_of_entities branch April 19, 2020 19:30
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants