Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Expected Behavior of Sonarr Upcoming Sensor #34408

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Restore Expected Behavior of Sonarr Upcoming Sensor #34408

merged 1 commit into from
Apr 24, 2020

Conversation

ctalkington
Copy link
Contributor

@ctalkington ctalkington commented Apr 19, 2020

Proposed change

My previous fix in #34224 worked but the documented behavior of days meant that doing +1day to the current time led to possibly having 2 days of shows rather than 1 day as the documentation prescribes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: sonarr small-pr PRs with less than 30 lines. labels Apr 19, 2020
@project-bot project-bot bot added this to Needs review in Dev Apr 19, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 19, 2020
@ghost
Copy link

ghost commented Apr 19, 2020

this works good here

@ctalkington ctalkington changed the title WIP: Restore Expected Behavior of Sonarr Upcoming Sensor Restore Expected Behavior of Sonarr Upcoming Sensor Apr 19, 2020
@ctalkington
Copy link
Contributor Author

this bugfix would be good candidate for next beta

@ctalkington ctalkington mentioned this pull request Apr 24, 2020
@balloob balloob added this to the 0.109.0 milestone Apr 24, 2020
@balloob balloob merged commit 1d22936 into home-assistant:dev Apr 24, 2020
Dev automation moved this from By Code Owner to Done Apr 24, 2020
@ctalkington
Copy link
Contributor Author

thanks @balloob, sorry for confusion on my part. i hide the (now resolved) comments on hotfix issue.

@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants