Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit clone/view stats to repos with push access #34575

Merged
merged 1 commit into from
Apr 23, 2020

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Apr 23, 2020

Breaking change

Proposed change

The views/clones stats that was added in #33300 require push access to the repo.
This PR, limits the fetching of those stats to only be gathered if the user has push access to the repo.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensor:
  - platform: github
    access_token: "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx"
    repositories:
      - path: "home-assistant/actions"
      - path: "hacs/bot"

Additional information

image
I do not have push access to "home-assistant/core", but have it to "hacs/bot".

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@ludeeus ludeeus added this to the 0.109.0 milestone Apr 23, 2020
@balloob balloob merged commit 4fa268e into dev Apr 23, 2020
@balloob balloob deleted the ludeeus/github/permissions branch April 23, 2020 19:42
@lock lock bot locked and limited conversation to collaborators Apr 25, 2020
@balloob balloob added the bugfix label May 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Sensor Error in 0.109.0b0
3 participants