-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mill config flow #35136
Add Mill config flow #35136
Conversation
Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with a integration ( |
@@ -52,11 +49,11 @@ | |||
) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(comment not related to line but to file)
For a future PR, we should register the service using move the service registration to entity_platform.async_register_entity_service
__init__.py
and make sure it works across config entries.
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: Paulus Schoutsen <balloob@gmail.com>
8ef080b
to
4ba9568
Compare
Looks like just the missing coverage for line 43,44 in
|
Nice job @Danielhiversen |
Breaking change
Mill can no longer be configured via configuration.yaml, configuration is now done though UI
Proposed change
Add config flow support to Mill integration
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: