-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Insteon backend module to pyinsteon from insteonplm #35198
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please be wary about the context of the functions and what api we're using, async or sync. Those need to match.
@MartinHjelmare Thanks for reviewing this PR. I know it was a pain in the ars given the number of changes required. |
@MartinHjelmare Any chance this makes it into 0.110.x? |
We're passed the beta cut for 0.110.0, so no. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I assume there is a bigger issue with tests right now since removing that .env file should not have broken anything. |
Breaking change
This PR will change the entity ID of some entities. Specifically the following entity types will be impacted:
Additionally, X10 entities for:
No longer appear as entities as they are not needed.
Proposed change
Change the backend module from
insteonplm
topyinsteon
. This change enables significant improvements to the Insteon component that include:All changes in the PR are specifically to enable the use of
pyinsteon
. The benefits above are a direct result of the use of the new module.Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: