Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netatmo data handler #35571

Merged
merged 139 commits into from
Aug 4, 2020
Merged

Conversation

cgtobi
Copy link
Contributor

@cgtobi cgtobi commented May 13, 2020

Breaking change

Proposed change

The data handling is changed to reduce the number of calls against the Netatmo API and the overall responsiveness is improved by taking advantage of webhook events if successfully established. Further it introduces the light platform to control the outdoor cameras flood light. It introduces services to set persons home/away in the Netatmo realm. The services to register and unregister the webhook with Netatmo manually is also brought back.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@project-bot project-bot bot added this to Needs review in Dev May 13, 2020
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev May 13, 2020
@cgtobi cgtobi added the waiting-for-upstream We're waiting for a change upstream label May 14, 2020
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from 9844e34 to cbdfbbd Compare May 15, 2020 18:51
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from 4e3df1b to 7e661a1 Compare June 10, 2020 07:59
@cgtobi cgtobi marked this pull request as ready for review June 18, 2020 07:29
@cgtobi cgtobi removed the waiting-for-upstream We're waiting for a change upstream label Jun 21, 2020
@MartinHjelmare MartinHjelmare moved this from Incoming to By Code Owner in Dev Jun 22, 2020
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from cedbe44 to 72a2a0d Compare July 9, 2020 08:56
@cgtobi cgtobi force-pushed the netatmo_data_handler branch 2 times, most recently from 5786afb to ac22617 Compare July 13, 2020 20:14
@cgtobi cgtobi merged commit 31dbdff into home-assistant:dev Aug 4, 2020
Dev automation moved this from Reviewer approved to Done Aug 4, 2020
homeassistant/components/netatmo/camera.py Show resolved Hide resolved
homeassistant/components/netatmo/camera.py Show resolved Hide resolved
homeassistant/components/netatmo/camera.py Show resolved Hide resolved
homeassistant/components/netatmo/camera.py Show resolved Hide resolved
homeassistant/components/netatmo/camera.py Show resolved Hide resolved
homeassistant/components/netatmo/light.py Show resolved Hide resolved
homeassistant/components/netatmo/light.py Show resolved Hide resolved
homeassistant/components/netatmo/sensor.py Show resolved Hide resolved
@cgtobi cgtobi deleted the netatmo_data_handler branch August 7, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

netatmo not working
4 participants