Switch Netatmo integration to dispatcher for internal communication #38590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgtobi
force-pushed
the
netatmo_climate_fix
branch
from
9047479
to
070974a
Compare
MartinHjelmare
requested changes
Aug 6, 2020
| @@ -69,7 +70,9 @@ async def async_setup(self): | |||
| ) | |||
|
|
|||
| self.listeners.append( | |||
| self.hass.bus.async_listen("netatmo_event", self.handle_event) | |||
| async_dispatcher_connect( | |||
| self.hass, f"signal-{DOMAIN}-webhook-None", self.handle_event, | |||
There was a problem hiding this comment.
When is the event type None? Is that what we're connecting to here?
There was a problem hiding this comment.
Yes, there are "system" related events like the acknowledgement of the established webhook that don't return an event type.
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
This is a follow up for #35571 to address the comments and suggestions by @MartinHjelmare.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: