-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Daikin yaml-support #35768
Conversation
f7b45dd
to
644a4b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
For the future, please don't squash commits after review has started to make it easier for readers to track changes.
Please update the breaking change paragraph with that the user should do to cope with the breaking change. |
I updated the breaking change paragraph to better explain the breaking change. |
As an end user it would be very helpful if a breaking change such as this had instructions and implications for a user. "All configuration should be done via the Integrations tab in the GUI." is very generic - and not that helpful for someone who has always configured via YAML.
It may be obvious for those that are always working with Home Assistant, but for those of us that have used it for years but don't fiddly daily, a little more instruction on breaking changes would be really useful. |
@charlietomo That is more a fitting comment on the release notes PR. Nevertheless, the answer is almost always the same, unless stated otherwise. YAML configuration is imported and can be safely removed. This import was already the case in previous releases, nothing changes. |
Noted - where would I find that PR? |
@charlietomo Nowhere, as there is no release being prepared at this time. |
Is there a reason this was deprecated and removed? Seems like it's a step backwards to force people to configure manually through the UI versus being able to codify their configuration. |
Breaking change
Configuration via YAML for the daikin integration is deprecated and will become invalid in release 0.113.0. All configuration should be done via the Integrations tab in the GUI. Users should remove the
daikin
configuration YAML section before 0.113.0 is released.Proposed change
Type of change
Example entry for
configuration.yaml
:DEPRICATED (YAY)
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: