Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Daikin yaml-support #35768

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

fredrike
Copy link
Contributor

@fredrike fredrike commented May 18, 2020

Breaking change

Configuration via YAML for the daikin integration is deprecated and will become invalid in release 0.113.0. All configuration should be done via the Integrations tab in the GUI. Users should remove the daikin configuration YAML section before 0.113.0 is released.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

DEPRICATED (YAY)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@MartinHjelmare MartinHjelmare changed the title Depricate Daikin yaml-support Deprecate Daikin yaml-support May 18, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For the future, please don't squash commits after review has started to make it easier for readers to track changes.

@MartinHjelmare
Copy link
Member

Please update the breaking change paragraph with that the user should do to cope with the breaking change.

@frenck frenck self-assigned this May 23, 2020
@frenck frenck merged commit 88ebdf3 into home-assistant:dev May 23, 2020
@MartinHjelmare
Copy link
Member

I updated the breaking change paragraph to better explain the breaking change.

@charlietomo
Copy link

As an end user it would be very helpful if a breaking change such as this had instructions and implications for a user. "All configuration should be done via the Integrations tab in the GUI." is very generic - and not that helpful for someone who has always configured via YAML.

  • Before or after upgrading to 113?
  • What happens to automations using the old Daikin setup?
  • What happens to homekit integrations that use Daikin?
  • What is the process to ensure a bunch of reconfiguration isn't needed?

It may be obvious for those that are always working with Home Assistant, but for those of us that have used it for years but don't fiddly daily, a little more instruction on breaking changes would be really useful.

@frenck
Copy link
Member

frenck commented Aug 1, 2020

@charlietomo That is more a fitting comment on the release notes PR.

Nevertheless, the answer is almost always the same, unless stated otherwise. YAML configuration is imported and can be safely removed. This import was already the case in previous releases, nothing changes.

@charlietomo
Copy link

@charlietomo That is more a fitting comment on the release notes PR.

Nevertheless, the answer is almost always the same, unless stated otherwise. YAML configuration is imported and can be safely removed. This import was already the case in previous releases, nothing changes.

Noted - where would I find that PR?

@frenck
Copy link
Member

frenck commented Aug 2, 2020

@charlietomo Nowhere, as there is no release being prepared at this time.

@jamesgoodhouse
Copy link

Is there a reason this was deprecated and removed? Seems like it's a step backwards to force people to configure manually through the UI versus being able to codify their configuration.

@frenck
Copy link
Member

frenck commented Sep 4, 2020

@jamesgoodhouse https://www.home-assistant.io/blog/2020/04/14/the-future-of-yaml/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants