-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
panel_custom: Allow ES5+latest build, deprecate html #36464
Conversation
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Can I ask a question? I'm using Also https://www.home-assistant.io/integrations/panel_custom/ doesn't say anything about it being deprecated I'm using it as:
And as far as I know i'm not using anything which is deprecated |
yes, please let us know, because there is some confusion on the way forward, a least for this. See https://community.home-assistant.io/t/z-wave-graph-without-the-python/64275/349 |
That integration needs to be rewritten to use JS as the entrypoint, not HTML. |
Why is this needed? Deprecation doesn't fix any issue (according to the above) |
HTML imports was a draft spec that was not accepted by the browsers. Only Chrome had it implemented and has since removed it. It requires Home Assistant to include extra logic and code to keep supporting it. If someone can write an HTML panel, they can write a JS panel. |
Thank you :) |
Breaking change
Specifying custom panels based on HTML imports is being deprecated and will be removed in a future version.
Proposed change
Allow specifying both an es5 + latest build for custom panels.
Deprecates specifying HTML panels.
Requires home-assistant/frontend#6104
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: