Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make panel_custom backwards compatible #36926

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Jun 19, 2020

Breaking change

Proposed change

#36464 accidentally broke the config option where if you specify no urls at all, we fall back to using the name to find an HTML file. This PR restores it.

Also adds a guard so we don't blow up when we see duplicate names for HTML panels. Fixes #36841

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@balloob balloob linked an issue Jun 19, 2020 that may be closed by this pull request
@frenck frenck added this to the 0.111.5 milestone Jun 19, 2020
@frenck frenck merged commit 263bdaa into dev Jun 19, 2020
@frenck frenck deleted the backwards-compat-panel-custom branch June 19, 2020 14:03
@frenck frenck removed this from the 0.111.5 milestone Jun 23, 2020
@lock lock bot locked and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during setup of component panel_custom, since HA 0.111.x
3 participants