Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade XS1 component to xs1-api-client v3.0.0 #36500

Merged
merged 2 commits into from
Jun 7, 2020
Merged

Upgrade XS1 component to xs1-api-client v3.0.0 #36500

merged 2 commits into from
Jun 7, 2020

Conversation

markusressel
Copy link
Contributor

@markusressel markusressel commented Jun 6, 2020

Proposed change

This updates the xs1-api-client dependency of the XS1 component to v3.0.0, which fixes a bug related to reordering of Gateway devices.

markusressel/xs1-api-client@v2.3.5...v3.0.0

When looking at the code I also found an invalid if condition check, probably introduced in the big HVAC_MODE migration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: xs1 small-pr PRs with less than 30 lines. labels Jun 6, 2020
@elupus
Copy link
Contributor

elupus commented Jun 6, 2020

Seems you are maintainer of lib, but i just wanted to check. Since it's major version bump of the library. It indicate API breaking changes in the lib, but i see no such changes here. There is no changes affecting HA's use here?

@markusressel
Copy link
Contributor Author

Yes, I am the maintainer. The breaking changes of the 3.0.0 release only affect certain methods, which are not used directly by the hass component, so there is no need to change anything.

@MartinHjelmare MartinHjelmare changed the title Upgraded XS1 component to xs1-api-client v3.0.0 Upgrade XS1 component to xs1-api-client v3.0.0 Jun 7, 2020
@MartinHjelmare MartinHjelmare merged commit 2332840 into home-assistant:dev Jun 7, 2020
@markusressel markusressel deleted the xs1_upgrade branch June 8, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed integration: xs1 small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants