Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ozw garage door barrier support #37316

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Add ozw garage door barrier support #37316

merged 4 commits into from
Jul 2, 2020

Conversation

firstof9
Copy link
Contributor

@firstof9 firstof9 commented Jul 2, 2020

Proposed change

Expand ozw cover support for BARRIER_OPERATOR class (Garage Doors)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

n/a

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @cgarwood, @marcelveldt, @MartinHjelmare, mind taking a look at this pull request as its been labeled with an integration (ozw) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! See comments below.

homeassistant/components/ozw/cover.py Outdated Show resolved Hide resolved
homeassistant/components/ozw/cover.py Outdated Show resolved Hide resolved
tests/components/ozw/test_cover.py Outdated Show resolved Hide resolved
tests/components/ozw/test_cover.py Outdated Show resolved Hide resolved
@firstof9
Copy link
Contributor Author

firstof9 commented Jul 2, 2020

I've addressed the requested changes in the latest commit @MartinHjelmare

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare changed the title Expand cover support for ozw Add ozw garage door barrier support Jul 2, 2020
@MartinHjelmare MartinHjelmare merged commit f6df85f into home-assistant:dev Jul 2, 2020
@firstof9 firstof9 deleted the ozw_garage_door branch November 17, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants