Updates to poolsense integration #37613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctalkington
requested changes
Jul 8, 2020
ctalkington
reviewed
Jul 9, 2020
ctalkington
reviewed
Jul 11, 2020
ctalkington
reviewed
Jul 11, 2020
ctalkington
reviewed
Jul 11, 2020
ctalkington
reviewed
Jul 11, 2020
| def __init__(self): | ||
| """Initialize PoolSense config flow.""" | ||
| self._email = None | ||
| self._password = None | ||
| self._errors = {} |
There was a problem hiding this comment.
_errors can be a local variable now.
There was a problem hiding this comment.
Thanks. Do I need to create a new PR to correct this or can I push it to this branch?
There was a problem hiding this comment.
This PR is merged so a new PR is required. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: