Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify vizio unique ID check since only IP and device class are needed #37692

Merged
merged 6 commits into from
Aug 12, 2020

Conversation

raman325
Copy link
Contributor

@raman325 raman325 commented Jul 9, 2020

Proposed change

When I originally implemented config_flow, I was under the impression that I needed an auth token before I can get the unique_id of a vizio device. I recently discovered that I only actually need the host and device_class to get the unique_id which means I can set it much earlier and detect for a duplicate sooner. As a result, I can remove duplicate logic and slightly simplify the config flow. I also added two missing typehints that I found and fixed some other typehints that pylance found errors for.

EDIT: The update to pyvizio was to remove the auth token as a parameter from the get_unique_id function.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@raman325 raman325 force-pushed the vizio_simplify_unique_id_check branch from ea3e4b3 to 6d60071 Compare August 7, 2020 02:47
@balloob balloob merged commit fbf44b3 into home-assistant:dev Aug 12, 2020
bahorn pushed a commit to bahorn/home-assistant-core that referenced this pull request Aug 12, 2020
@raman325 raman325 deleted the vizio_simplify_unique_id_check branch October 10, 2020 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants