Simplify vizio unique ID check since only IP and device class are needed #37692
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When I originally implemented
config_flow
, I was under the impression that I needed an auth token before I can get theunique_id
of avizio
device. I recently discovered that I only actually need thehost
anddevice_class
to get theunique_id
which means I can set it much earlier and detect for a duplicate sooner. As a result, I can remove duplicate logic and slightly simplify the config flow. I also added two missing typehints that I found and fixed some other typehints thatpylance
found errors for.EDIT: The update to
pyvizio
was to remove the auth token as a parameter from theget_unique_id
function.Type of change
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: