Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove evohome hvac_action as it is inaccurate #38244

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Remove evohome hvac_action as it is inaccurate #38244

merged 1 commit into from
Jul 27, 2020

Conversation

zxdavb
Copy link
Contributor

@zxdavb zxdavb commented Jul 26, 2020

Breaking change

The hvac_action() property has been removed from Evohome zones as this data was clearly inaccurate - the algorithm used to provide this data was not reliable, and there is no reasonable hope for a satisfactory alternative.

The user will have no indication if a zone is actively calling for heat (CURRENT_HVAC_*), nor if the heat source is currently active. However, they will continue to have the hvac_mode() property, which will indicate if the heating is enabled, or not (HVAC_MODE_*).

This will be most obvious to the end user by the absence of this information in the UI. A detailed explanation, with a specific example can be seen in #29559.

This is a breaking change, and there is no intervention required from the end-user.

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@KTibow
Copy link
Contributor

KTibow commented Jul 26, 2020

Random thing @zxdavb: you can mark a PR as a draft instead of putting "WIP" in there.

@zxdavb
Copy link
Contributor Author

zxdavb commented Jul 26, 2020

Yeah - I'm a bit rusty & I forgot!

@zxdavb zxdavb changed the title WIP: Remove hvac_action() (it is inaccurate) WIP: Remove hvac_action() as it is inaccurate Jul 26, 2020
@zxdavb zxdavb marked this pull request as draft July 26, 2020 16:56
@zxdavb zxdavb changed the title WIP: Remove hvac_action() as it is inaccurate Remove hvac_action() as it is inaccurate Jul 26, 2020
@zxdavb zxdavb marked this pull request as ready for review July 26, 2020 20:10
@zxdavb
Copy link
Contributor Author

zxdavb commented Jul 26, 2020

@MartinHjelmare A small/simple PR, but as a breaking change, would you please cast an eye over it for me?

@MartinHjelmare MartinHjelmare changed the title Remove hvac_action() as it is inaccurate Remove evohome hvac_action as it is inaccurate Jul 27, 2020
@MartinHjelmare MartinHjelmare merged commit 26bb604 into home-assistant:dev Jul 27, 2020
@zxdavb zxdavb deleted the bugfix_remove_hvac_action branch August 16, 2020 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

evohome hvac_action() (active / call for heat) is inaccurate
4 participants