Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup rfxtrx event listener directly #38298

Merged
merged 1 commit into from
Jul 27, 2020

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Jul 27, 2020

Should not be problem now that we use dispatcher for other events.

Proposed change

No point in waiting for start event anymore since we use dispatcher

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Should not be problem now that we use dispatcher for other events.
@elupus
Copy link
Contributor Author

elupus commented Jul 27, 2020

I can't see a reason to wait for hass.state == running, so i skipped doing it.

@probot-home-assistant
Copy link

Hey there @Danielhiversen, mind taking a look at this pull request as its been labeled with an integration (rfxtrx) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title Setup event listener directly Setup rfxtrx event listener directly Jul 27, 2020
@MartinHjelmare MartinHjelmare merged commit c3966a5 into home-assistant:dev Jul 27, 2020
@elupus elupus deleted the rftrx_fixup_reload branch July 28, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants