Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary lock pip to 20.1.1 to avoid build issue #38358

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Temporary lock pip to 20.1.1 to avoid build issue #38358

merged 1 commit into from
Jul 29, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Jul 29, 2020

Proposed change

This PR pins/locks the PIP version used in our CI to the previous version 20.1.1.
It seems like 20.2 causes issues, not sure why yet. Our CI issues started after they released 20.2.

To not block builds, this places a lock on the version used.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Jul 29, 2020
@frenck frenck mentioned this pull request Jul 29, 2020
Merged
20 tasks
@frenck frenck marked this pull request as ready for review July 29, 2020 13:31
@frenck frenck merged commit 417e00e into dev Jul 29, 2020
@frenck frenck deleted the frenck-2020-0723 branch July 29, 2020 13:31
@frenck frenck mentioned this pull request Jul 29, 2020
Merged
20 tasks
bannhead pushed a commit to bannhead/core that referenced this pull request Jul 29, 2020
@frenck @bannhead
Temporary lock pip to 20.1.1 to avoid build issue (home-assistant#38358)
b2207ed
bannhead added a commit to bannhead/core that referenced this pull request Jul 31, 2020
@bannhead
Revert "Temporary lock pip to 20.1.1 to avoid build issue (home-assis…
10d440b 
…tant#38358)"

This reverts commit b2207ed.
bannhead added a commit to bannhead/core that referenced this pull request Jul 31, 2020
@bannhead
Revert "Temporary lock pip to 20.1.1 to avoid build issue (home-assis…
9c0b83b 
…tant#38358)"

This reverts commit b2207ed.
balloob pushed a commit that referenced this pull request Aug 1, 2020
@frenck @balloob
Temporary lock pip to 20.1.1 to avoid build issue (#38358)
c4fcd8b
@balloob balloob mentioned this pull request Aug 1, 2020
Merged
cgtobi pushed a commit that referenced this pull request Aug 4, 2020
@bannhead @starkillerOG
@BKPepe @frenck @JeffLIrion @ehendrix23 @bachya @jjlawren @bdraco @cgarwood
Bump pyaehw4a1 to 0.3.9 (#38347)
45e4512 
* Bump pyaehw4a1 to 0.3.9

* Add myself to xiaomi miio codeowners (#38350)

* add myself to xiaomi miio codeowners

* Update CODEOWNERS

* Update manifest.json

* Upgrade youtube_dl to version 2020.07.28 (#38328)

* Temporary lock pip to 20.1.1 to avoid build issue (#38358)

* Add wheels job for building core wheels (#38359)

* Bump androidtv to 0.0.47 and adb-shell to 0.2.1 (#38344)

* Add jobs names to Wheels builds (#38363)

* Update aioharmony to 0.2.6 (#38360)

* Update run-in-env.sh (#36577)

* Bump aioambient to 1.2.0 (#38364)

* Bump simplisafe-python to 9.2.2 (#38365)

* Ignore remote Plex clients during plex.tv lookup (#38327)

* Avoid error with ignored harmony config entries (#38367)

* Bump ElkM1 library version. (#38368)

To reduce required version of dependent library.
No code changed.

* Add basic websocket api for OZW (#38265)

* Prevent nut config flow error when checking ignored entries (#38372)

* Revert "Prevent nut config flow error when checking ignored entries (#38372)"

This reverts commit 9e0530d.

* Revert "Add basic websocket api for OZW (#38265)"

This reverts commit 3ca93ba.

* Revert "Bump ElkM1 library version. (#38368)"

This reverts commit 143f55a.

* Revert "Avoid error with ignored harmony config entries (#38367)"

This reverts commit 90a10ba.

* Revert "Ignore remote Plex clients during plex.tv lookup (#38327)"

This reverts commit 67cdeaf.

* Revert "Bump simplisafe-python to 9.2.2 (#38365)"

This reverts commit 01d68e0.

* Revert "Bump aioambient to 1.2.0 (#38364)"

This reverts commit bec6904.

* Revert "Update run-in-env.sh (#36577)"

This reverts commit 53acc1b.

* Revert "Update aioharmony to 0.2.6 (#38360)"

This reverts commit a991d6f.

* Revert "Add jobs names to Wheels builds (#38363)"

This reverts commit 58dcc05.

* Revert "Bump androidtv to 0.0.47 and adb-shell to 0.2.1 (#38344)"

This reverts commit 14b4722.

* Revert "Add wheels job for building core wheels (#38359)"

This reverts commit cb9e76a.

* Revert "Temporary lock pip to 20.1.1 to avoid build issue (#38358)"

This reverts commit b2207ed.

* Revert "Upgrade youtube_dl to version 2020.07.28 (#38328)"

This reverts commit 144e827.

* Revert "Add myself to xiaomi miio codeowners (#38350)"

This reverts commit 8853825.

Co-authored-by: starkillerOG <starkiller.og@gmail.com>
Co-authored-by: Josef Schlehofer <pepe.schlehofer@gmail.com>
Co-authored-by: Franck Nijhof <git@frenck.dev>
Co-authored-by: Jeff Irion <JeffLIrion@users.noreply.github.com>
Co-authored-by: ehendrix23 <hendrix_erik@hotmail.com>
Co-authored-by: Aaron Bach <bachya1208@gmail.com>
Co-authored-by: jjlawren <jjlawren@users.noreply.github.com>
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: Glenn Waters <gwwaters@gmail.com>
Co-authored-by: Charles Garwood <cgarwood@gmail.com>
balloob added a commit that referenced this pull request Aug 26, 2020
@balloob
Revert "Temporary lock pip to 20.1.1 to avoid build issue (#38358)"
9eea7a5 
This reverts commit 417e00e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@frenck @MartinHjelmare @balloob @homeassistant