Exclude disabled entities from device class lookup

[chrisaljoudi]

Proposed change

async_get_device_class_lookup shouldn't include disabled entities in the returned lookup table.

This resolves an issue where HomeKit Bridge takes those disabled entities into consideration when determining the characteristics to expose to HomeKit.

For example, if a user disabled the battery sensor entity for a thermostat device (for example, because it's wired), async_get_device_class_lookup would still include that in the returned lookup table, subsequently causing HomeKit bridge to utilize that entity and advertise it to HomeKit even though it's disabled, in turn causing many warnings when the state turns out to be missing:

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[Jc2k]

Could you update the tests for this helper to include a test case for this change? The existing test is here.

Would also be good if you could add tests to homekit as well. We could do with making sure there are tests there for when the primary entity is disabled (if there aren't already) as well as when as the secondary "linked" entities like batteries you mention are disabled (which there presumably arent yet).

[bdraco]

This is a good change, but as Jc2k points out, it needs tests.

[stale]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

[frenck]

Closing this PR as stale. Feel free to re-open when ready to work on it again.