Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OVO Energy Sensors #38849

Merged
merged 6 commits into from
Aug 14, 2020
Merged

Fix OVO Energy Sensors #38849

merged 6 commits into from
Aug 14, 2020

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Aug 13, 2020

Proposed change

Tested over a few hours. All seems well and updates/does not set an unknown state

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • 🥈 Silver

@timmo001 timmo001 changed the base branch from dev to master August 13, 2020 16:36
@timmo001 timmo001 changed the base branch from master to dev August 13, 2020 16:36
@MartinHjelmare MartinHjelmare changed the title Fixes for OVO Energy Sensors Fix OVO Energy Sensors Aug 13, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

return await client.get_daily_usage(now.strftime("%Y-%m"))
except aiohttp.ClientError as exception:
_LOGGER.warning(exception)
return None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future in another PR, we can start a reauth step in the config flow here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good plan 😸

@MartinHjelmare MartinHjelmare merged commit 47d1920 into home-assistant:dev Aug 14, 2020
@timmo001 timmo001 deleted the ovo-fixes branch August 14, 2020 12:09
@frenck
Copy link
Member

frenck commented Aug 14, 2020

Should this go into a patch release?

@timmo001
Copy link
Contributor Author

Should this go into a patch release?

If possible please, along with #38835 / 1f3b9bc

👍

@frenck frenck added this to the 0.114.1 milestone Aug 14, 2020
balloob pushed a commit that referenced this pull request Aug 15, 2020
@balloob balloob mentioned this pull request Aug 15, 2020
weissm pushed a commit to weissm/core that referenced this pull request Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OVO Energy Integration
5 participants