-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the first seen context data in the logbook api #39194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
context_entity_id is the first entity seen during a time period that includes the context
bdraco
force-pushed
the
context_entity_id
branch
from
August 23, 2020 20:06
7bb1f66
to
69f4315
Compare
9 tasks
balloob
reviewed
Aug 24, 2020
balloob
reviewed
Aug 24, 2020
bdraco
changed the title
Include the context_entity_id in the logbook api
Include the context in the logbook api
Aug 24, 2020
bdraco
changed the title
Include the context in the logbook api
Include the first seen context data in the logbook api
Aug 24, 2020
balloob
approved these changes
Aug 24, 2020
Revalidating performance, then will merge, and rework the frontend PR |
groups are missing context. Will fix that in another PR |
weissm
pushed a commit
to weissm/core
that referenced
this pull request
Aug 28, 2020
…t#39194) * Include the context_entity_id in the logbook api context_entity_id is the first entity seen during a time period that includes the context * update test * more of them * include friendly name * pylint wants a ternary * Refactor * performance * fix homekit context * Fix self describing events * Fix external_events
leikoilja
pushed a commit
to leikoilja/core
that referenced
this pull request
Sep 6, 2020
…t#39194) * Include the context_entity_id in the logbook api context_entity_id is the first entity seen during a time period that includes the context * update test * more of them * include friendly name * pylint wants a ternary * Refactor * performance * fix homekit context * Fix self describing events * Fix external_events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cla-signed
core
has-tests
integration: logbook
WTH
Issues & PRs generated from the "Month of What the Heck?"
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WTH: https://community.home-assistant.io/t/what-the-heck-turned-my-light-on/219488
Frontend change: home-assistant/frontend#6682
Proposed change
Include the context_entity_id in the logbook api
context_entity_id is the first entity seen during
a time period that includes the context
Limitations:
Service Call:
Automation
State change (show which entity triggered the template entity to change)
HomeKit
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: