Axis - Improve naming of some events #39699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: axis
new-feature
small-pr
Kane610
force-pushed
the
axis-better_event_names
branch
from
8855edd
to
57694e5
Compare
bdraco
reviewed
Sep 6, 2020
| and event_data | ||
| and self.event.id in event_data | ||
| ): | ||
| return f"{self.device.name} {self.event.TYPE} {event_data[self.event.id].name}" |
There was a problem hiding this comment.
Should we mark this a breaking change in case anyone was matching for specific text?
bdraco
approved these changes
Sep 6, 2020
|
Thanks for the review @bdraco |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Initial naming of events from VMD4 and Fence guard are now based on their configured name on the device; 'binary_sensor.m1065-lw_0_vmd4_camera1profile1' is now 'binary_sensor.m1065-lw_0_vmd4_profile_1' or 'profile_1' can be whatever the user chose to name the profile.
Proposed change
Library now calls APIs of applications and this data can be used to improve naming of entities.
Specifically for Fence guard, Loitering guard, Motion guard, VMD4
This also fixes a small issue with parsing users which could break during certain conditions
Library changes: Kane610/axis@v33...v34
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: