Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing EDL21 OBIS codes #39714

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Conversation

DAMEK86
Copy link
Contributor

@DAMEK86 DAMEK86 commented Sep 6, 2020

Breaking change

Proposed change

Iskraemeco MT175 supports instantaneous power for all phases. This results in multiple "Unhandled sensor detected" warnings in HA.
Missing OBIS codes for active instantaneous power phases are added, sensors appear in HA, and waring goes away.
Add support for instantaneous power for all phases (L1, L2, L3).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
sensors:
  - platform: edl21
    serial_port: /dev/ttyAMA1

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

fixes home-assistant#39712
Iskraemeco MT175 supports instantaneous power for all phases (L1,L2,L3). This results in multiple Unhandled sensor detected warnings in HA.
Missing OBIS codes for active instantaneous power phases are added, sensors apear in HA and waring goes away.

Signed-off-by: Andreas Rehn <rehn.andreas86@gmail.com>
@homeassistant
Copy link
Contributor

Hi @DAMEK86,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant
Copy link

Hey there @mtdcr, mind taking a look at this pull request as its been labeled with an integration (edl21) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@mtdcr
Copy link
Contributor

mtdcr commented Sep 6, 2020

Looks good to me. Thank you, @DAMEK86!

@MartinHjelmare MartinHjelmare changed the title EDL21: add missing OBIS codes Add missing EDL21 OBIS codes Sep 8, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit c68056d into home-assistant:dev Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EDL21: Unhandled sensor
4 participants