Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Shelly sensors #39747

Merged
merged 3 commits into from
Sep 7, 2020
Merged

Rework Shelly sensors #39747

merged 3 commits into from
Sep 7, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 7, 2020

Breaking change

Proposed change

Reworks Shelly sensors to:

  • use an attribute descriptor class with helper entity
  • sensors are now tied to block type + attribute name instead of just attribute name
  • Use same infra for binary sensors
  • Add sensor index to name if multiple blocks with same type

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bieniu, mind taking a look at this pull request as its been labeled with an integration (shelly) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@balloob balloob merged commit b07628a into dev Sep 7, 2020
@balloob balloob deleted the shelly-sensor branch September 7, 2020 12:13
@bieniu
Copy link
Member

bieniu commented Sep 7, 2020

@balloob Was that the intention to remove some sensors? For example, the power sensor for some devices is in relay block, for some in device for others in emeter.

@balloob
Copy link
Member Author

balloob commented Sep 7, 2020

Those need to be added back but felt out of scope for this PR. For now I just picked one of the types that had them. Used data from the new verify script for this home-assistant-libs/aioshelly#11

@bieniu
Copy link
Member

bieniu commented Sep 7, 2020

I understand, I was not sure if this is an intended change. In the evening I will add the missing sensors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants