Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of quoted time_pattern values #40470

Merged
merged 2 commits into from
Sep 23, 2020

Conversation

amelchio
Copy link
Contributor

Breaking change

Proposed change

In #38982 I accidentally removed a vol.Coerce(int) which means that

  minutes: "12"

ends up being treated as

  minutes:
    - 1
    - 2

because the string is iterable. This PR brings back the coercion within the custom validator.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
  trigger:
    - platform: time_pattern
      minutes: '30'

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@amelchio amelchio added this to the 0.115.3 milestone Sep 22, 2020
@amelchio amelchio changed the title Accept quoted time_pattern values Fix handling of quoted time_pattern values Sep 22, 2020
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: J. Nick Koston <nick@koston.org>
@frenck frenck merged commit 7876cdb into home-assistant:dev Sep 23, 2020
frenck added a commit that referenced this pull request Sep 25, 2020
Co-authored-by: J. Nick Koston <nick@koston.org>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time_pattern automation triggers only reading the first digit.
4 participants