Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indentify IKEA and Phillips motion sensors correctly #41111

Merged
merged 1 commit into from
Oct 3, 2020

Conversation

abmantis
Copy link
Contributor

@abmantis abmantis commented Oct 3, 2020

Breaking change

Proposed change

Previously, IKEA and Hue motion sensors where getting the "opening" device class. This identifies them on ZHA so that they get the "motion" class.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Adminiuga
Copy link
Contributor

You may have to find that Ikea motion sensor in zha_devices_list.py and update the entity class. Will provide more info when not on the phone

@abmantis abmantis marked this pull request as ready for review October 3, 2020 21:03
Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Philips is shown as a motion sensor, but I can't get it to send anything nor I believe it was sending anything before. If it is not supposed to work, then i'll address it in a separate PR

@Adminiuga Adminiuga merged commit 4aacc87 into home-assistant:dev Oct 3, 2020
@abmantis abmantis deleted the zha_onoff_motion branch October 6, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants