Switch to asyncio.wait for slow update warning implementation #41184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
changed the title
elupus
reviewed
Oct 4, 2020
bdraco
added a commit
that referenced
this pull request
Apr 8, 2023
I had originally changed this to create a task and wait in #41184 but that does not make sense anymore with newer cpython as the profile now shows the original method is cheaper (or I did it wrong the first time)
20 tasks
balloob
pushed a commit
that referenced
this pull request
Apr 9, 2023
…91067) * Switch back to using call_later for the slow entity update warning I had originally changed this to create a task and wait in #41184 but that does not make sense anymore with newer cpython as the profile now shows the original method is cheaper (or I did it wrong the first time) * fix missing block till done since there is no longer a task being created which would run the event loop once
tetele
pushed a commit
to tetele/ha-core
that referenced
this pull request
Apr 11, 2023
…ome-assistant#91067) * Switch back to using call_later for the slow entity update warning I had originally changed this to create a task and wait in home-assistant#41184 but that does not make sense anymore with newer cpython as the profile now shows the original method is cheaper (or I did it wrong the first time) * fix missing block till done since there is no longer a task being created which would run the event loop once
tkhadimullin
pushed a commit
to tkhadimullin/ha-core
that referenced
this pull request
Apr 13, 2023
…ome-assistant#91067) * Switch back to using call_later for the slow entity update warning I had originally changed this to create a task and wait in home-assistant#41184 but that does not make sense anymore with newer cpython as the profile now shows the original method is cheaper (or I did it wrong the first time) * fix missing block till done since there is no longer a task being created which would run the event loop once
teharris1
pushed a commit
to teharris1/home-assistant
that referenced
this pull request
Apr 18, 2023
…ome-assistant#91067) * Switch back to using call_later for the slow entity update warning I had originally changed this to create a task and wait in home-assistant#41184 but that does not make sense anymore with newer cpython as the profile now shows the original method is cheaper (or I did it wrong the first time) * fix missing block till done since there is no longer a task being created which would run the event loop once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Switch to asyncio.wait for slow update warning implementation
Before:
After:
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: