Switch back to using call_later for the slow entity update warning #91067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had originally changed this to create a task and wait in #41184 but that does not make sense anymore with newer cpython as the profile now shows the original method is cheaper (or I did it wrong the first time)
…ated which would run the event loop once
bdraco
commented
Apr 8, 2023
| @@ -1274,6 +1274,7 @@ async def test_unavailable_device( | |||
| hass.config_entries.async_update_entry( | |||
| config_entry_mock, options={CONF_POLL_AVAILABILITY: True} | |||
| ) | |||
| await hass.async_block_till_done() | |||
There was a problem hiding this comment.
Since there is no longer a task being created in async_update_entity via async_device_update the async_update_entry call wasn't finishing before the entity update started.
balloob
approved these changes
Apr 9, 2023
|
Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
I had originally changed this to create a task and wait in #41184 but that does not make sense anymore at least with newer
cpython(in hindsight, I don't think it was a good change than either) as the profile now shows the original method is cheaper when I subtract the execution time of the update function.While
cpythonhas had quite a few improvements in scheduling performance since 2020 and thats helping here, I'm pretty sure I did the profiling wrong in 2020 and didn't account for the task creation moving the execution of the update coro to another branch which hid it from the original profile. 🤦 I never noticed this difference in previous profiles over the last few years since so much has moved to useDataUpdateCoordinatorwhich kept moving the execution path away from here so it never was large enough to pop up until I created a lot ofrestsensors for testing another issue.before (we only care about the cost of the
waitas we assume the execution of the update function to be constant):after (we only care about the cost of
call_laterandcancelas we assume the execution of the update function to be constant). In this case since there is no task creation we see the actual execution happening lower in the stack:Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: