Improve uvc test camera #41438
Merged
Improve uvc test camera #41438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
Hacktoberfest
code-quality
has-tests
integration: uvc
small-pr
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
emontnemery
reviewed
Mar 18, 2021
There was a problem hiding this comment.
@sycx2: This looks good, but needs to be rebased as there is a new test test_motion_recording_mode_properties added on dev branch.
MartinHjelmare
force-pushed
the
improve_uvc_test_camera
branch
from
16c0879
to
cea6a15
Compare
MartinHjelmare
approved these changes
Mar 18, 2021
raman325
pushed a commit
to raman325/home-assistant
that referenced
this pull request
Mar 24, 2021
* Improve uvc test camera * Clean setup full config * Clean setup partial config * Set more camera defaults * Clean setup partial config v31x * Clean setup incomplete config * Clean setup nvr errors during indexing * Clean setup nvr errors during initialization * Clean properties * Fix motion recording mode properties * Clean stream * Clean login * Clean login v31x * Clean login tries both addres and caches * Clean login fails both properly * Remove not needed test * Clean camera image error * Test snapshot login retry * Clean up * Test enable and disable motion detection * Times must be UTC Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
last_recording_start_timestate attribute of the uvc camera entity was changed from local time to be UTC time. All times in state attributes must be UTC time. Users should update any automations or scripts that depend on this state attribute.Proposed change
Improves the tests for the uvc camera by rewriting tests to async pytest functions.
I changed a lot in this test so it may need some review.
Also I got a logical understanding problem which you can find in the mentioned issue or at this link:
#40906 (comment)
All tests are passing.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: