-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicated attribute request from ZHA #41442
Conversation
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with an integration ( |
ed50cac
to
85e541b
Compare
you may want to update isort and/or re-run script/setup from core repo. Lint complains on imports order |
@Adminiuga I run isort on the file and it changes, then black complains when the commit hook is run, and changes it back 🤷 |
Make sure you have the same black version? Try running script/setup from the latest dev branch. |
@Adminiuga yes, just pulled the latest dev and ran script/setup |
The on_off attribute is on the REPORT_CONFIG, so super().async_initialize already requests it from the device. No need to request it twice.
56ec5e0
to
a702b40
Compare
The problem was having zigpy dir inside HA repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed change
The on_off attribute is on the REPORT_CONFIG, so super().async_initialize already requests it from the device.
No need to request it twice. This should make the init of a new device a bit faster.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: