Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated attribute request from ZHA #41442

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

abmantis
Copy link
Contributor

@abmantis abmantis commented Oct 7, 2020

Proposed change

The on_off attribute is on the REPORT_CONFIG, so super().async_initialize already requests it from the device.
No need to request it twice. This should make the init of a new device a bit faster.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with an integration (zha) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@Adminiuga
Copy link
Contributor

you may want to update isort and/or re-run script/setup from core repo. Lint complains on imports order

@abmantis
Copy link
Contributor Author

abmantis commented Oct 8, 2020

@Adminiuga I run isort on the file and it changes, then black complains when the commit hook is run, and changes it back 🤷

@Adminiuga
Copy link
Contributor

Make sure you have the same black version? Try running script/setup from the latest dev branch.

@abmantis
Copy link
Contributor Author

abmantis commented Oct 8, 2020

@Adminiuga yes, just pulled the latest dev and ran script/setup

The on_off attribute is on the REPORT_CONFIG, so
super().async_initialize already requests it from the device.
No need to request it twice.
@abmantis
Copy link
Contributor Author

abmantis commented Oct 8, 2020

The problem was having zigpy dir inside HA repo.

Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adminiuga Adminiuga merged commit 078ecef into home-assistant:dev Oct 9, 2020
@abmantis abmantis deleted the zha_duplicated_request branch October 9, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants