Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Browse Media to Xbox #41776

Merged
merged 5 commits into from Oct 13, 2020
Merged

Conversation

hunterjm
Copy link
Member

@hunterjm hunterjm commented Oct 13, 2020

Proposed change

This adds browse media to the Xbox media player allowing users to navigate to the Dashboard, Live TV (if configured on the device), or launch any installed app or game.

image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
xbox:
  client_id: !secret xbox_client_id
  client_secret: !secret xbox_client_secret

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@project-bot project-bot bot added this to Needs review in Dev Oct 13, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 13, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Directories should have media class directory and children media class corresponding to the directory content.

homeassistant/components/xbox/browse_media.py Outdated Show resolved Hide resolved
homeassistant/components/xbox/browse_media.py Outdated Show resolved Hide resolved
homeassistant/components/xbox/browse_media.py Outdated Show resolved Hide resolved
Dev automation moved this from By Code Owner to Review in progress Oct 13, 2020
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from Review in progress to Reviewer approved Oct 13, 2020
@hunterjm
Copy link
Member Author

Do I need separate docs for the browse media feature, or is home-assistant/home-assistant.io#15223 sufficient?

@MartinHjelmare
Copy link
Member

We can extend that docs PR, if it's not ready for merge yet. We should probably document the play media service, ie what media content type and media content id is accepted. The browse media feature doesn't need to be documented as such.

@hunterjm
Copy link
Member Author

Docs PR updated. LGTM!

@MartinHjelmare MartinHjelmare merged commit c3ccea5 into home-assistant:dev Oct 13, 2020
Dev automation moved this from Reviewer approved to Done Oct 13, 2020
@hunterjm hunterjm deleted the xbox-media-browse branch October 13, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants