Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xbox documentation #15223

Merged
merged 14 commits into from Oct 20, 2020
Merged

Add Xbox documentation #15223

merged 14 commits into from Oct 20, 2020

Conversation

hunterjm
Copy link
Member

Proposed change

Add documentation for the Xbox Integration.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant bot added has-parent This PR has a parent PR in a other repo next This PR goes into the next branch Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! labels Oct 12, 2020
@MartinHjelmare MartinHjelmare added the parent-merged The parent PR has been merged already label Oct 13, 2020
@MartinHjelmare
Copy link
Member

Should we mention what consoles are supported? It looks like it's only Xbox One and later?

@frenck frenck added this to To Do in New documentation via automation Oct 13, 2020
@frenck frenck added the new-integration This PR adds documentation for a new Home Assistant integration label Oct 13, 2020
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@hunterjm
Copy link
Member Author

Ok, I'm done adding changes for 0.117 :)

@SeanPM5
Copy link
Contributor

SeanPM5 commented Oct 16, 2020

For the media source section, it might be worth including a brief mention about potential delays in newly downloaded content appearing in the Media Browser.

When I downloaded a few extra media player apps on my console to test this integration, it took ~21 hours for them to appear in HA. Not sure if that's a consistent behavior though...

New documentation automation moved this from To Do to Awaiting Parent PR Oct 20, 2020
MartinHjelmare
MartinHjelmare previously approved these changes Oct 20, 2020
@hunterjm
Copy link
Member Author

LGTM

MartinHjelmare
MartinHjelmare previously approved these changes Oct 20, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hunterjm 👍

Awesome work 🎉

@frenck frenck merged commit 39377a8 into home-assistant:next Oct 20, 2020
New documentation automation moved this from Awaiting Parent PR to Done Oct 20, 2020
@probot-home-assistant probot-home-assistant bot removed the parent-merged The parent PR has been merged already label Oct 20, 2020
@hunterjm hunterjm deleted the xbox branch October 21, 2020 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest An PR on this issue (or the PR itself) is eligible towards Hacktoberfest! has-parent This PR has a parent PR in a other repo new-integration This PR adds documentation for a new Home Assistant integration next This PR goes into the next branch
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants