Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mysensors to use async_add_executor_job #41849

Merged
merged 2 commits into from
Oct 15, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 14, 2020

Proposed change

Update mysensors to use async_add_executor_job

There was a check to see if a device is a serial port that
did not, AFAICT, do IO and did not need to be run in the executor
It's actually calling os.stat(value) under the hood.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

There was a check to see if a device is a serial port that
did not IO that did not need to be run in the executor
@probot-home-assistant
Copy link

Hey there @MartinHjelmare, mind taking a look at this pull request as its been labeled with an integration (mysensors) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@bdraco bdraco merged commit 4187234 into home-assistant:dev Oct 15, 2020
@bdraco bdraco deleted the mysensors_async_add_executor_job branch October 15, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants