Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot use vcgencmd in HassOS #42710

Merged
merged 9 commits into from
Nov 23, 2020
Merged

Cannot use vcgencmd in HassOS #42710

merged 9 commits into from
Nov 23, 2020

Conversation

denics
Copy link
Contributor

@denics denics commented Nov 1, 2020

Stop using native rpi vcgencmd in favor of a more universal cat

Proposed change

SenseHAT integration code still rely on vcgencmd to read CPU temperature. However this is unavailable in HassOS and breaks the integration. The more universal cat /sys/class/thermal/thermal_zone0/temp read the temperature in all RPi OSs.

If this PR is merged, a little change should be done to the example in the documentation, as I show here.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
  - platform: sensehat
    display_options:
      - temperature
      - humidity
      - pressure
  - platform: template
    sensors:
      sensehat_temperature:
        value_template: '{{ states("sensor.temperature") | round(1) }}'
        unit_of_measurement: '°C'
      sensehat_pressure:
        value_template: '{{ states("sensor.pressure") | round(1) }}'
        unit_of_measurement: 'mb'
      sensehat_humidity:
        value_template: '{{ states("sensor.humidity") | round(1) }}'
        unit_of_measurement: '%'

Additional information

  • This PR fixes or closes issue: fixes Sense Hat does not work on HassOS #42708
  • This PR is related to issue: NA
  • Link to documentation pull request: NA, but willing to add the example as soon as this is accepted.

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

RTIMUlib requires to be installed manually. TODO
resolved comment
solved comment to PR. use strip instead of replace
forgot to import pathlib
serious problems with my cut&paste!
fixed flake8: E221 multiple spaces before operator
fix black: 1 file reformatted, 2 files left unchanged.
fix isort
@cgarwood cgarwood merged commit 66efe92 into home-assistant:dev Nov 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sense Hat does not work on HassOS
5 participants