Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing sensor exceptions in SimpliSafe #42845

Merged
merged 3 commits into from
Nov 4, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Nov 4, 2020

Proposed change

Previously, SimpliSafe binary sensors were looking for supported data in too many places, leading to unhandled exceptions. This PR streamlines how sensor entities are defined and created to avoid this scenario now and in the future.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Nov 4, 2020
@bachya bachya changed the title Ss sensor types Fix missing sensor exceptions in SimpliSafe Nov 4, 2020
@bachya bachya added this to the 0.117.5 milestone Nov 4, 2020
@bachya bachya removed this from the 0.117.5 milestone Nov 4, 2020
@bachya bachya merged commit 5b754c2 into home-assistant:dev Nov 4, 2020
@bachya bachya deleted the ss-sensor-types branch November 4, 2020 19:36
@bachya bachya added this to the 0.117.5 milestone Nov 4, 2020
balloob pushed a commit that referenced this pull request Nov 5, 2020
* Fix missing sensor exceptions in SimpliSafe

* Entity types

* Don't overdo it
@balloob balloob mentioned this pull request Nov 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants