-
-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xiamoi_miio the water_box / mop status #43355
Add xiamoi_miio the water_box / mop status #43355
Conversation
This pull request needs to be manually signed off by @home-assistant/core before it can get merged. |
Hey there @rytilahti, @syssi, @starkillerOG, mind taking a look at this pull request as its been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks straightforward to me, how about the naming of the variable? Should it be about the water box or the mop?
I was kinda confused by the naming as wel. For the S5 Max that I have here this property only becomes true if I connect the mop to the robot, whereas the waterbox is always connected. So for me this naming is more intuitive, but I'm unsure how other models handle this. |
Hmm, I see, that's a tricky one but I'm open to have it as For the naming of the state attribute, I just checked if any other vacuum mentions mopping, and looks like only |
Let's merge this for now. |
Proposed change
I would like to track the mop status to enable reminders to use the mop after a certain time has passed.
Here is a link to the relevant function of the miio dependency:
https://github.com/rytilahti/python-miio/blob/master/miio/vacuumcontainers.py#L173
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: