Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return unique id of Blink binary sensor #43942

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

brg468
Copy link
Contributor

@brg468 brg468 commented Dec 4, 2020

Proposed change

Return the unique_id for Blink binary sensors. Allows the binary sensors to show up under Blink on the integrations page (they were hard to find otherwise) and allows customizing the entities from the UI.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @fronzbot, mind taking a look at this pull request as its been labeled with an integration (blink) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@fronzbot
Copy link
Contributor

fronzbot commented Dec 4, 2020

LGTM 👍

@frenck frenck added this to the 1.0.0 milestone Dec 5, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This looks like a bug to me; as it was placed on all platforms, except this one (while still creating the unique_id).

👍

@frenck frenck merged commit c5adaa1 into home-assistant:dev Dec 5, 2020
frenck pushed a commit that referenced this pull request Dec 5, 2020
@brg468 brg468 deleted the blink-add-unique-id branch December 5, 2020 16:21
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants