Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate siri requests to turn on thermostats to valid targets #44236

Merged
merged 1 commit into from Dec 24, 2020

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 14, 2020

Proposed change

Translate siri requests to turn on thermostats to valid targets

Siri always requests auto mode even when the device does not
support auto which results in the thermostat failing to turn
on as success is assumed. We now determine the heat cool
target mode based on the current temp, target temp, and
supported modes to ensure the thermostat will reach the
requested target temp.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

Siri always requests auto mode even when the device does not
support auto which results in the thermostat failing to turn
on as success is assumed.  We now determine the heat cool
target mode based on the current temp, target temp, and
supported modes to ensure the thermostat will reach the
requested target temp.
@project-bot project-bot bot added this to Needs review in Dev Dec 14, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Dec 14, 2020
Dev automation moved this from By Code Owner to Reviewer approved Dec 22, 2020
@bdraco
Copy link
Member Author

bdraco commented Dec 24, 2020

Thanks 馃憤

@bdraco bdraco merged commit 677fc6e into home-assistant:dev Dec 24, 2020
Dev automation moved this from Reviewer approved to Done Dec 24, 2020
KJonline pushed a commit to Pyhass/core that referenced this pull request Dec 24, 2020
* 'dev' of https://github.com/home-assistant/core: (145 commits)
  Periodically attempt to discover new wemo devices (home-assistant#44361)
  Translate siri requests to turn on thermostats to valid targets (home-assistant#44236)
  Fix filter sensor None state (home-assistant#44439)
  [ci skip] Translation update
  Motion Blinds upgrade to local push (home-assistant#44391)
  Bump hyperion-py to 0.6.1 (home-assistant#44490)
  [ci skip] Translation update
  Move Legacy Works With Nest integration to subdirectory (home-assistant#44368)
  Remove Travis CI config (home-assistant#44443)
  Bump codecov/codecov-action from v1.1.0 to v1.1.1 (home-assistant#44442)
  Fix KNX issue if 0 kelvin is reported by device (home-assistant#44392)
  KNX BinarySensor takes float values for `reset_after` (home-assistant#44446)
  Fix Volumio pause with missing track type (home-assistant#44447)
  [ci skip] Translation update
  Support area on entities for google assistant (home-assistant#44300)
  Add ecobee humidity attributes (home-assistant#44366)
  Cleanup and optimization for Zerproc (home-assistant#44430)
  Add additional debug launch methods in launch.json (home-assistant#44419)
  Reduce IPP errors when printer is offline (home-assistant#44413)
  Update denonavr to 0.9.9 (home-assistant#44411)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Thermostat does not turn on (HomeKit Controller)
3 participants