Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyroon to 0.0.28 #44302

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Bump pyroon to 0.0.28 #44302

merged 1 commit into from
Dec 16, 2020

Conversation

pavoni
Copy link
Contributor

@pavoni pavoni commented Dec 16, 2020

Proposed change

This PR bumps pyroon from 0.0.25 to 0.0.28

The only impact on HA is that this fixes a problem caused by the new roon release (1.7) which prevents the play_media command correctly playing radio stations.

The updated library contains a number of changes relating to improving roon discovery - which are not currently used by HA. It also removes some unused facilities that are not used by HA.

At some point I will update the roon component to the new discovery - but not in this PR.

Library changes here:-

pavoni/pyroon@0.0.25...0.0.28

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Bump pyroon to 0.0.28 - fixes problem with playing radio in roon 1.7. Bump pyroon to 0.0.28 Dec 16, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit 638374c into dev Dec 16, 2020
@MartinHjelmare MartinHjelmare deleted the bump_pyroon_fix_radio branch December 16, 2020 23:01
@MartinHjelmare
Copy link
Member

Should we tag it for a possible patch release?

@pavoni
Copy link
Contributor Author

pavoni commented Dec 16, 2020

Yes, please, it would be great to include it in the next patch.

@MartinHjelmare MartinHjelmare added this to the 2020.12.2 milestone Dec 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants