Add Ondilo ico integration #44728
Merged
Add Ondilo ico integration #44728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JeromeHXP, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
probot-home-assistant
bot
added
has-tests
new-integration
integration: ondilo_ico
labels
This was referenced Jan 1, 2021
allenporter
reviewed
Jan 1, 2021
allenporter
reviewed
Jan 1, 2021
allenporter
reviewed
Jan 1, 2021
allenporter
reviewed
Jan 1, 2021
- Inherit CoordinatorEntity instead of Entity - Merged pools blocking calls into one - Renamed devices vars to sensors - Check supported sensor types - Stop relying on array index position for pools - Stop relying on attribute position in dict for sensors
|
I'm happy to look again -- The diffs look like they may be including other stuff, so maybe a rebase is in order? |
JeromeHXP
force-pushed
the
Ondilo_ICO_integration
branch
2 times, most recently
from
be08c96
to
069f073
Compare
@allenporter Yep sorry I messed up with my rebase. It should be clean now. |
allenporter
approved these changes
Jan 4, 2021
allenporter
approved these changes
Jan 4, 2021
|
Looks great, happy new year! |
frenck
reviewed
Jan 4, 2021
KJonline
pushed a commit
to Pyhass/core
that referenced
this pull request
Jan 4, 2021
* 'dev' of https://github.com/home-assistant/core: (207 commits) Fix zeroconf outgoing dns compression corruption for large packets (home-assistant#44828) Move RainMachine services to entity services (home-assistant#44139) Updated Ondilo translation files to remove title (home-assistant#44824) Adjust system info for lovelace with multiple dashboards (home-assistant#44796) Add Ondilo ico integration (home-assistant#44728) Fix Fan support in nest climate by adding HVAC_MODE_FAN_ONLY support (home-assistant#44203) Add device entry id to events (home-assistant#44407) Try to fix flaky Risco test (home-assistant#44788) Add myself to codeowners for Shelly (home-assistant#44814) Cleanup timeouts values for Shelly (home-assistant#44790) Change rest sensors update interval for Shelly Motion (home-assistant#44692) Add more debug details to running timeouts (home-assistant#43644) Change WHITELIST to ALLOWLIST for websockets (home-assistant#44766) Fix bug with blink auth flow (home-assistant#44769) Fix race when handling MQTT discovery messages (home-assistant#44730) Drop remaining Python < 3.8 support (home-assistant#44743) Bump pyobihai (home-assistant#44768) Add index to old_state_id column for postgres and older databases (home-assistant#44757) Bumo pyroon version to 0.0.30 (home-assistant#44800) Update to denonavr version 0.9.10 (home-assistant#44791) ...
21 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Adds a new component to be able to retrieve Ondilo ICO data using Ondilo's APIs. ICOs are small connected devices that you simply drop into the pool or spa and continuously analyzes the water quality.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: