Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ecobee humidifier #45003

Merged
merged 13 commits into from Apr 12, 2021
Merged

Add Ecobee humidifier #45003

merged 13 commits into from Apr 12, 2021

Conversation

treylok
Copy link
Contributor

@treylok treylok commented Jan 10, 2021

Proposed change

Add ability to set the humidifier mode of an ecobee thermostat with a humidifier attached.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @marthoc, mind taking a look at this pull request as its been labeled with an integration (ecobee) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@github-actions

This comment has been minimized.

@github-actions github-actions bot added the stale label Feb 14, 2021
@frenck
Copy link
Member

frenck commented Feb 14, 2021

Not stale, awaiting our review.

@frenck frenck removed the stale label Feb 14, 2021
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Mar 15, 2021
@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 16, 2021
Copy link
Contributor

@bjpetit bjpetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment/question regarding service schema.

homeassistant/components/ecobee/climate.py Outdated Show resolved Hide resolved
@treylok treylok marked this pull request as draft March 26, 2021 18:43
@github-actions github-actions bot closed this Apr 2, 2021
Dev automation moved this from Needs review to Cancelled Apr 2, 2021
@MartinHjelmare MartinHjelmare reopened this Apr 2, 2021
Dev automation moved this from Cancelled to Incoming Apr 2, 2021
@treylok treylok marked this pull request as ready for review April 3, 2021 01:35
Dev automation moved this from Incoming to Review in progress Apr 3, 2021
homeassistant/components/ecobee/const.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/humidifier.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/humidifier.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/humidifier.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/humidifier.py Outdated Show resolved Hide resolved
homeassistant/components/ecobee/humidifier.py Outdated Show resolved Hide resolved
tests/components/ecobee/test_humidifier.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one comment.

homeassistant/components/ecobee/climate.py Outdated Show resolved Hide resolved
Dev automation moved this from Review in progress to Reviewer approved Apr 12, 2021
@treylok
Copy link
Contributor Author

treylok commented Apr 12, 2021

Should I close the documentation pull request since using the HumidifierEntity makes it irrelevant?

@MartinHjelmare
Copy link
Member

MartinHjelmare commented Apr 12, 2021

We should at least add Humidifier to the ha_category and humidifier to the ha_platforms front matter YAML in the docs page.

@MartinHjelmare MartinHjelmare changed the title Ecobee add humidifier mode Add Ecobee humidifier Apr 12, 2021
@MartinHjelmare MartinHjelmare merged commit 7256e33 into home-assistant:dev Apr 12, 2021
Dev automation moved this from Reviewer approved to Done Apr 12, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2021
@treylok treylok deleted the ecobee_add_humidifier_mode branch October 17, 2021 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants